Closed mhsnprvr closed 3 months ago
Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.
We had Typechain before but it added a lot of bloat. I'm fine with it only if you can add it as a dev dependency
Conflicts
Do you not have contributor access to our repo yet?
Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.
We had Typechain before but it added a lot of bloat. I'm fine with it only if you can add it as a dev dependency
sure, I'll add it
Failing tests š¤
let me see
Do you not have contributor access to our repo yet?
nope, asked in a channel, no response
Failing tests š¤
isn't it related to env variables?
Failing tests š¤
isn't it related to env variables?
Other PRs aren't having the same problem, is it because it's a PR from a forked repo? š¤
Failing tests š¤
isn't it related to env variables?
Other PRs aren't having the same problem, is it because it's a PR from a forked repo? š¤
it might be, is it possible to test on your machine?
Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.
We had Typechain before but it added a lot of bloat. I'm fine with it only if you can add it as a dev dependency
about typechain suggestion, I understood today that alternative approaches are better (since typechain stopped the development), but I saw some errors in types of contracts using it, so maybe it's better if viem usage gets improved
Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.
PR-Codex overview
The focus of this PR is to update file paths, import types, and fix potentially incorrect V values in signatures.
Detailed summary
ERC20_ABI
toERC20.ts
SMART_ACCOUNT_INFO
object toConstants.ts
getABISVMSessionKeyData
function parameter types