bcnmy / biconomy-client-sdk

Biconomy SDK is a plug & play toolkit for dApps to build transaction legos that enable a highly customised one-click experience for their users
MIT License
76 stars 78 forks source link

fix:some cleanup #520

Closed mhsnprvr closed 3 months ago

mhsnprvr commented 4 months ago

Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.


PR-Codex overview

The focus of this PR is to update file paths, import types, and fix potentially incorrect V values in signatures.

Detailed summary

The following files were skipped due to too many changes: src/modules/MultichainValidationModule.ts, src/paymaster/BiconomyPaymaster.ts, src/account/BaseSmartContractAccount.ts, src/modules/utils/Helper.ts, src/account/BiconomySmartAccountV2.ts

āœØ Ask PR-Codex anything about this PR by commenting with /codex {your question}

joepegler commented 4 months ago

Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.

We had Typechain before but it added a lot of bloat. I'm fine with it only if you can add it as a dev dependency

joepegler commented 4 months ago

Conflicts

joepegler commented 4 months ago

Do you not have contributor access to our repo yet?

mhsnprvr commented 4 months ago

Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.

We had Typechain before but it added a lot of bloat. I'm fine with it only if you can add it as a dev dependency

sure, I'll add it

mhsnprvr commented 4 months ago

Failing tests šŸ¤”

let me see

mhsnprvr commented 4 months ago

Do you not have contributor access to our repo yet?

nope, asked in a channel, no response

mhsnprvr commented 4 months ago

Failing tests šŸ¤”

isn't it related to env variables?

joepegler commented 4 months ago

Failing tests šŸ¤”

isn't it related to env variables?

Other PRs aren't having the same problem, is it because it's a PR from a forked repo? šŸ¤”

mhsnprvr commented 4 months ago

Failing tests šŸ¤”

isn't it related to env variables?

Other PRs aren't having the same problem, is it because it's a PR from a forked repo? šŸ¤”

it might be, is it possible to test on your machine?

mhsnprvr commented 4 months ago

Recommendation: While I may not be very familiar with the codebase, I propose the adoption of TypeChain. it can significantly streamline the development process by automatically generating TypeScript typings for Ethereum smart contracts. By doing so, it can alleviate a considerable amount of overhead for developers, ensuring type safety and enhancing productivity.

We had Typechain before but it added a lot of bloat. I'm fine with it only if you can add it as a dev dependency

about typechain suggestion, I understood today that alternative approaches are better (since typechain stopped the development), but I saw some errors in types of contracts using it, so maybe it's better if viem usage gets improved