search

bcnmy / biconomy-client-sdk

Biconomy SDK is a plug & play toolkit for dApps to build transaction legos that enable a highly customised one-click experience for their users
MIT License
76 stars 78 forks source link

chore: fix some comments #558

Closed bytetigers closed 2 months ago

bytetigers commented 2 months ago

PR-Codex overview

This PR improves code consistency by fixing typos and clarifying comments in various files.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

darrenvechain commented 2 months ago

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

https://github.com/hyperium/tonic/pull/1869 https://github.com/vechain/thor/pull/817 https://github.com/sushiswap/sushiswap/pull/1606 https://github.com/ReactiveX/RxJava/pull/7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files https://github.com/harmony-one/harmony/pull/4734 https://github.com/RunOnFlux/flux/pull/1387 https://github.com/gluwa/creditcoin/pull/1688
https://github.com/bandprotocol/chain/pull/415
https://github.com/centrifuge/centrifuge-chain/pull/1963
https://github.com/bcnmy/biconomy-client-sdk/pull/558

bytetigers commented 2 months ago

Hi, FYI this looks like a bot farming trust. The user has raised 12 PRs in as many minutes, fixing only typos.

hyperium/tonic#1869 vechain/thor#817 sushiswap/sushiswap#1606 ReactiveX/RxJava#7749 https://github.com/UMAprotocol/protocol/pull/4778/files https://github.com/zcash/librustzcash/pull/1494/files harmony-one/harmony#4734 RunOnFlux/flux#1387 https://github.com/gluwa/creditcoin/pull/1688
https://github.com/bandprotocol/chain/pull/415
https://github.com/centrifuge/centrifuge-chain/pull/1963
https://github.com/bcnmy/biconomy-client-sdk/pull/558

First of all, I am not a robot. I submitted all of them manually. Some of the identification and judgment took a lot of time.

I submitted a method to fix the method name to the https://github.com/vechain/thor/pulls project you maintain. If you think it is worthless, you can close it. Please don't think that others are like you and think it is insignificant.

Don't comment under each PR, which reflects your self-righteousness and poor quality.

As the maintainer of this project said, I don't think there is anything wrong with such changes https://github.com/gluwa/creditcoin/pull/1688

joepegler commented 2 months ago

Closing, these comments will be removed in upcoming version of sdk anyway