bcnmy / metatx-standard

Repository contains generalized meta transaction standard that can be added to any smart contract to allow Meta Transactions from any externally-owned (key-based) account.
MIT License
141 stars 63 forks source link

Not supporting Big Numbers >1e10 for BSC #13

Open bhargav55 opened 3 years ago

bhargav55 commented 3 years ago

USDC in BSC has 18 decimals, so need support for values in the range 1e18 for meta transactions.

Getting the below error when trying to use big numbers, However it is working well with normal txns without Biconomy

Uncaught (in promise) Error: invalid hexlify value (operation="checkSafeInteger", fault="out-of-safe-range", value=1000000000000000000, code=NUMERIC_FAULT, version=bytes/5.0.10)

bhargav55 commented 3 years ago

Steps to reproduce it,

  1. create a custom token with 18 decimals.
  2. Approve certain amount(token.approve) in wei as allowance for any user2 from user1.
  3. Transfer the allowance(token.transferFrom) by user2 from user1 to user3.