search

bcnmy / nexus

Nexus by Biconomy: ERC-7579 Modular Smart Account for Enhanced Account Abstraction
https://github.com/bcnmy/nexus/wiki
MIT License
27 stars 5 forks source link

calltype check in fallback flow #131

Closed livingrockrises closed 3 months ago

livingrockrises commented 3 months ago

https://cantina.xyz/code/d1d4b139-9705-4367-9468-297b7078674e/findings/17

do check review comment as well.

github-actions[bot] commented 3 months ago

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary - [constable-states](#constable-states) (2 results) (Optimization) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-0 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/7bc6c61101c82e511011323944f747fcef95aeca/contracts/contracts/base/RegistryAdapter.sol#L12)) should be constant [base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/7bc6c61101c82e511011323944f747fcef95aeca/contracts/contracts/base/RegistryAdapter.sol#L12) - [ ] ID-1 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/7bc6c61101c82e511011323944f747fcef95aeca/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/7bc6c61101c82e511011323944f747fcef95aeca/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.

openzeppelin-code[bot] commented 3 months ago

calltype check in fallback flow

Generated at commit: cd3a15532c35b9e4bc252efe3d1eb9831eedbdf1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
1
0
6
24
31

For more details view the full report in OpenZeppelin Code Inspector

livingrockrises commented 3 months ago

this I wanna club with https://github.com/bcnmy/nexus/pull/132 cause it could cause merging issues.

Aboudjem commented 3 months ago

also similar to codehaws #214

Aboudjem commented 3 months ago

Do you plan to add tests here, or should I do it?

livingrockrises commented 3 months ago

Do you plan to add tests here, or should I do it?

go ahead

livingrockrises commented 3 months ago

wait till other PR is merged. or I will move this code to other one. Can make list of pending tests to be written @Aboudjem

livingrockrises commented 3 months ago

moving this to other PR