search

bcnmy / nexus

Nexus by Biconomy: ERC-7579 Modular Smart Account for Enhanced Account Abstraction
https://github.com/bcnmy/nexus/wiki
MIT License
27 stars 5 forks source link

hooking upgradeToAndCall #141

Closed livingrockrises closed 3 months ago

github-actions[bot] commented 3 months ago

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [locked-ether](#locked-ether) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## locked-ether :yellow_circle: Impact: Medium :red_circle: Confidence: High - [ ] ID-0 Contract locking ether found: Contract [Bootstrap]([utils/RegistryBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/utils/RegistryBootstrap.sol#L33-L165)) has payable functions: - [ModuleManager.receive()]([base/ModuleManager.sol#L71](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/base/ModuleManager.sol#L71)) - [ModuleManager.fallback()]([base/ModuleManager.sol#L74-L124](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/base/ModuleManager.sol#L74-L124)) But does not have a function to withdraw the ether [utils/RegistryBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/utils/RegistryBootstrap.sol#L33-L165) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-1 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/base/RegistryAdapter.sol#L12)) should be constant [base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/base/RegistryAdapter.sol#L12) - [ ] ID-2 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/520de225d46fa4070c97f3aea7db8deb04af27bf/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.

openzeppelin-code[bot] commented 3 months ago

hooking upgradeToAndCall

Generated at commit: 80d3913bc04d10a682d8a193d31437c910a2ffc7

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
1
0
7
24
32

For more details view the full report in OpenZeppelin Code Inspector

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.19%. Comparing base (626a3a2) to head (80d3913). Report is 25 commits behind head on remediations/cantina-spearbit.

Files Patch % Lines
contracts/Nexus.sol 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## remediations/cantina-spearbit #141 +/- ## ================================================================= + Coverage 71.86% 72.19% +0.32% ================================================================= Files 13 13 Lines 686 694 +8 Branches 126 150 +24 ================================================================= + Hits 493 501 +8 Misses 193 193 ``` | [Files](https://app.codecov.io/gh/bcnmy/nexus/pull/141?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) | Coverage Δ | | |---|---|---| | [contracts/Nexus.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/141?src=pr&el=tree&filepath=contracts%2FNexus.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL05leHVzLnNvbA==) | `63.06% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/bcnmy/nexus/pull/141/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/141?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/141?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [da18b3d...80d3913](https://app.codecov.io/gh/bcnmy/nexus/pull/141?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).