bcnmy / nexus

Nexus by Biconomy: ERC-7579 Modular Smart Account for Enhanced Account Abstraction
https://github.com/bcnmy/nexus/wiki
MIT License
27 stars 5 forks source link

add comment and remove _SELF #142

Closed livingrockrises closed 3 months ago

github-actions[bot] commented 3 months ago

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [locked-ether](#locked-ether) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## locked-ether :yellow_circle: Impact: Medium :red_circle: Confidence: High - [ ] ID-0 Contract locking ether found: Contract [Bootstrap]([utils/RegistryBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/utils/RegistryBootstrap.sol#L33-L165)) has payable functions: - [ModuleManager.receive()]([base/ModuleManager.sol#L71](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/base/ModuleManager.sol#L71)) - [ModuleManager.fallback()]([base/ModuleManager.sol#L74-L124](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/base/ModuleManager.sol#L74-L124)) But does not have a function to withdraw the ether [utils/RegistryBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/utils/RegistryBootstrap.sol#L33-L165) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-1 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/base/RegistryAdapter.sol#L12)) should be constant [base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/base/RegistryAdapter.sol#L12) - [ ] ID-2 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/f00406363df22e5d7804947dde8b1d9e72bd8154/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.

openzeppelin-code[bot] commented 3 months ago

add comment and remove _SELF

Generated at commit: 84c09410ae15d719d9721ca6d615ea8977b231b0

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
1
0
7
24
32

For more details view the full report in OpenZeppelin Code Inspector

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.49%. Comparing base (80d3913) to head (84c0941). Report is 38 commits behind head on remediations/cantina-spearbit.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## remediations/cantina-spearbit #142 +/- ## ================================================================= + Coverage 72.19% 75.49% +3.30% ================================================================= Files 13 13 Lines 694 657 -37 Branches 150 126 -24 ================================================================= - Hits 501 496 -5 + Misses 193 161 -32 ``` | [Files](https://app.codecov.io/gh/bcnmy/nexus/pull/142?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) | Coverage Δ | | |---|---|---| | [contracts/Nexus.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/142?src=pr&el=tree&filepath=contracts%2FNexus.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL05leHVzLnNvbA==) | `62.85% <ø> (-0.22%)` | :arrow_down: | | [contracts/base/ExecutionHelper.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/142?src=pr&el=tree&filepath=contracts%2Fbase%2FExecutionHelper.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2Jhc2UvRXhlY3V0aW9uSGVscGVyLnNvbA==) | `56.38% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/142?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/142?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [0070740...84c0941](https://app.codecov.io/gh/bcnmy/nexus/pull/142?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).