use execessivelyselfcall

[livingrockrises]

malicious module can still force revert with this fix. since there can be cases that can burn gas

https://github.com/nomad-xyz/ExcessivelySafeCall

[openzeppelin-code[bot]]

use execessivelyselfcall

Generated at commit: 52872a0e4cc7980b8ef2146ad88982643d1355bd

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	0 1 0 7 24 32

---

For more details view the full report in OpenZeppelin Code Inspector

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.53%. Comparing base (80d3913) to head (52872a0). Report is 41 commits behind head on remediations/cantina-spearbit.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## remediations/cantina-spearbit #143 +/- ## ================================================================= + Coverage 72.19% 75.53% +3.34% ================================================================= Files 13 13 Lines 694 658 -36 Branches 150 126 -24 ================================================================= - Hits 501 497 -4 + Misses 193 161 -32 ``` | [Files](https://app.codecov.io/gh/bcnmy/nexus/pull/143?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) | Coverage Δ | | |---|---|---| | [contracts/base/ModuleManager.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/143?src=pr&el=tree&filepath=contracts%2Fbase%2FModuleManager.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2Jhc2UvTW9kdWxlTWFuYWdlci5zb2w=) | `83.63% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/143?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/143?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [0070740...52872a0](https://app.codecov.io/gh/bcnmy/nexus/pull/143?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).

[github-actions[bot]]

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [locked-ether](#locked-ether) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## locked-ether :yellow_circle: Impact: Medium :red_circle: Confidence: High - [ ] ID-0 Contract locking ether found: Contract [Bootstrap]([utils/RegistryBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/utils/RegistryBootstrap.sol#L33-L165)) has payable functions: - [ModuleManager.receive()]([base/ModuleManager.sol#L72](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/base/ModuleManager.sol#L72)) - [ModuleManager.fallback()]([base/ModuleManager.sol#L75-L125](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/base/ModuleManager.sol#L75-L125)) But does not have a function to withdraw the ether [utils/RegistryBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/utils/RegistryBootstrap.sol#L33-L165) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-1 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/base/RegistryAdapter.sol#L12)) should be constant [base/RegistryAdapter.sol#L12](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/base/RegistryAdapter.sol#L12) - [ ] ID-2 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/8953be7d30b22fe452ee9747feffe504afe3dc0d/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.