search

bcnmy / nexus

Nexus by Biconomy: ERC-7579 Modular Smart Account for Enhanced Account Abstraction
https://github.com/bcnmy/nexus/wiki
MIT License
27 stars 5 forks source link

update modifier #163

Closed livingrockrises closed 2 months ago

github-actions[bot] commented 2 months ago

Changes to gas cost

Generated at commit: 87c804636ff73916a490fe6354b0bcc13a954093, compared to commit: 00c6663e5d4dabec8367e889c55573c17ab47268

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %
Full diff report 👇
| Contract | Deployment Cost (+/-) | Method | Min (+/-) | % | Avg (+/-) | % | Median (+/-) | % | Max (+/-) | % | # Calls (+/-) | |:-|-:|:-|-:|-:|-:|-:|-:|-:|-:|-:|-:| | **Nexus** | 6,164,160 (-25,677) | | | | | | | | | | |
github-actions[bot] commented 2 months ago

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [unused-return](#unused-return) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## unused-return :yellow_circle: Impact: Medium :yellow_circle: Confidence: Medium - [ ] ID-0 [ERC7739Validator._hashTypedDataForAccount(address,bytes32)]([base/ERC7739Validator.sol#L176-L206](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/base/ERC7739Validator.sol#L176-L206)) ignores return value by [(name,version,chainId,verifyingContract) = EIP712(account).eip712Domain()]([base/ERC7739Validator.sol#L177-L185](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/base/ERC7739Validator.sol#L177-L185)) [base/ERC7739Validator.sol#L176-L206](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/base/ERC7739Validator.sol#L176-L206) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-1 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/base/RegistryAdapter.sol#L10)) should be constant [base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/base/RegistryAdapter.sol#L10) - [ ] ID-2 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/87c804636ff73916a490fe6354b0bcc13a954093/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.

openzeppelin-code[bot] commented 2 months ago

update modifier

Generated at commit: 910ca49ef81b0f91d8131782dd9b9fbbc0facae4

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 0
1
0
7
25
33

For more details view the full report in OpenZeppelin Code Inspector

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.39%. Comparing base (00c6663) to head (910ca49). Report is 2 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #163 +/- ## ======================================= Coverage 93.39% 93.39% ======================================= Files 14 14 Lines 727 727 Branches 165 165 ======================================= Hits 679 679 Misses 48 48 ``` | [Files with missing lines](https://app.codecov.io/gh/bcnmy/nexus/pull/163?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) | Coverage Δ | | |---|---|---| | [contracts/Nexus.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/163?src=pr&el=tree&filepath=contracts%2FNexus.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL05leHVzLnNvbA==) | `94.48% <100.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/163?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/163?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [00c6663...910ca49](https://app.codecov.io/gh/bcnmy/nexus/pull/163?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).