bcnmy / nexus

Nexus by Biconomy: ERC-7579 Modular Smart Account for Enhanced Account Abstraction
https://github.com/bcnmy/nexus/wiki
MIT License
27 stars 5 forks source link

feat: added MockTokenWithPermit to deployment script #165

Closed VGabriel45 closed 2 months ago

github-actions[bot] commented 2 months ago

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [unused-return](#unused-return) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## unused-return :yellow_circle: Impact: Medium :yellow_circle: Confidence: Medium - [ ] ID-0 [ERC7739Validator._hashTypedDataForAccount(address,bytes32)]([base/ERC7739Validator.sol#L176-L206](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/base/ERC7739Validator.sol#L176-L206)) ignores return value by [(name,version,chainId,verifyingContract) = EIP712(account).eip712Domain()]([base/ERC7739Validator.sol#L177-L185](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/base/ERC7739Validator.sol#L177-L185)) [base/ERC7739Validator.sol#L176-L206](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/base/ERC7739Validator.sol#L176-L206) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-1 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/base/RegistryAdapter.sol#L10)) should be constant [base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/base/RegistryAdapter.sol#L10) - [ ] ID-2 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/6c70af94a3f802bd30c7f7d36855f181e94e7e54/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.94%. Comparing base (fe2d426) to head (df36e38). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #165 +/- ## ========================================== + Coverage 93.39% 93.94% +0.55% ========================================== Files 14 14 Lines 727 727 Branches 140 165 +25 ========================================== + Hits 679 683 +4 + Misses 48 44 -4 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/bcnmy/nexus/pull/165/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/165?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/165?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [fe2d426...df36e38](https://app.codecov.io/gh/bcnmy/nexus/pull/165?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).