bcnmy / nexus

Nexus by Biconomy: ERC-7579 Modular Smart Account for Enhanced Account Abstraction
https://github.com/bcnmy/nexus/wiki
MIT License
27 stars 5 forks source link

Feat/remap fix #170

Closed Aboudjem closed 1 month ago

openzeppelin-code[bot] commented 2 months ago

Feat/remap fix

Generated at commit: 9e8e1e63af89eaf5d054205d14535bac93deab23

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
1
0
7
25
33

For more details view the full report in OpenZeppelin Code Inspector

livingrockrises commented 1 month ago

checks either skipped / failing. there is no functionality changes in contract code in any way right?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.68%. Comparing base (be4ae46) to head (84d9317). Report is 30 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #170 +/- ## ========================================== - Coverage 86.40% 85.68% -0.73% ========================================== Files 14 14 Lines 905 922 +17 Branches 266 253 -13 ========================================== + Hits 782 790 +8 - Misses 109 117 +8 - Partials 14 15 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/bcnmy/nexus/pull/170?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) | Coverage Δ | | |---|---|---| | [contracts/Nexus.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2FNexus.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL05leHVzLnNvbA==) | `85.05% <ø> (ø)` | | | [contracts/base/BaseAccount.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Fbase%2FBaseAccount.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2Jhc2UvQmFzZUFjY291bnQuc29s) | `97.36% <ø> (ø)` | | | [contracts/base/ERC7739Validator.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Fbase%2FERC7739Validator.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2Jhc2UvRVJDNzczOVZhbGlkYXRvci5zb2w=) | `91.66% <ø> (ø)` | | | [contracts/base/ModuleManager.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Fbase%2FModuleManager.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2Jhc2UvTW9kdWxlTWFuYWdlci5zb2w=) | `86.75% <ø> (ø)` | | | [contracts/common/Stakeable.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Fcommon%2FStakeable.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2NvbW1vbi9TdGFrZWFibGUuc29s) | `100.00% <ø> (ø)` | | | [contracts/factory/K1ValidatorFactory.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Ffactory%2FK1ValidatorFactory.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2ZhY3RvcnkvSzFWYWxpZGF0b3JGYWN0b3J5LnNvbA==) | `100.00% <100.00%> (ø)` | | | [contracts/factory/NexusAccountFactory.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Ffactory%2FNexusAccountFactory.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2ZhY3RvcnkvTmV4dXNBY2NvdW50RmFjdG9yeS5zb2w=) | `95.23% <ø> (ø)` | | | [contracts/factory/RegistryFactory.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Ffactory%2FRegistryFactory.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL2ZhY3RvcnkvUmVnaXN0cnlGYWN0b3J5LnNvbA==) | `70.42% <100.00%> (ø)` | | | [contracts/modules/validators/K1Validator.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Fmodules%2Fvalidators%2FK1Validator.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL21vZHVsZXMvdmFsaWRhdG9ycy9LMVZhbGlkYXRvci5zb2w=) | `70.37% <ø> (-6.20%)` | :arrow_down: | | [contracts/utils/NexusBootstrap.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/170?src=pr&el=tree&filepath=contracts%2Futils%2FNexusBootstrap.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL3V0aWxzL05leHVzQm9vdHN0cmFwLnNvbA==) | `100.00% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/170?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/170?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [be4ae46...84d9317](https://app.codecov.io/gh/bcnmy/nexus/pull/170?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).
github-actions[bot] commented 1 month ago

Changes to gas cost

Generated at commit: 244b3cae014af89d8e217ed2237faf63b0e1a5d1, compared to commit: be4ae467f531337836f3c8fe5050694522d48670

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %
Nexus accountId
executeFromExecutor
-110 ✅
-2,809 ✅
-17.97%
-13.83%
BootstrapLib createArrayConfig -97 ✅ -5.77%

Full diff report 👇
| Contract | Deployment Cost (+/-) | Method | Min (+/-) | % | Avg (+/-) | % | Median (+/-) | % | Max (+/-) | % | # Calls (+/-) | |:-|-:|:-|-:|-:|-:|-:|-:|-:|-:|-:|-:| | **Nexus** | 4,690,358 (-90,377) | _accountId_
_execute_
_executeFromExecutor_
_initializeAccount_
_installModule_
_isModuleInstalled_
_uninstallModule_
_validateUserOp_ | 502 (-110)
3,785 (-2,523)
12,182 (-2,582)
113,140 (-1,260)
32,474 (-38)
855 (-10)
5,837 (-31)
13,859 (-49) | **-17.97%**
**-40.00%**
**-17.49%**
**-1.10%**
**-0.12%**
**-1.16%**
**-0.53%**
**-0.35%** | 502 (-110)
46,243 (-193)
17,501 (-2,809)
132,974 (-1,260)
38,162 (-61)
1,176 (-16)
10,536 (-78)
15,431 (-49) | **-17.97%**
**-0.42%**
**-13.83%**
**-0.94%**
**-0.16%**
**-1.34%**
**-0.73%**
**-0.32%** | 502 (-110)
37,985 (-23)
17,434 (-2,804)
133,040 (-1,260)
39,842 (-31)
1,152 (-16)
12,307 (-158)
13,859 (-49) | **-17.97%**
**-0.06%**
**-13.86%**
**-0.94%**
**-0.08%**
**-1.37%**
**-1.27%**
**-0.35%** | 502 (-110)
143,063 (-23)
22,956 (-3,045)
133,040 (-1,260)
44,137 (-54)
3,196 (-16)
12,421 (-45)
42,740 (-53) | **-17.97%**
**-0.02%**
**-11.71%**
**-0.94%**
**-0.12%**
**-0.50%**
**-0.36%**
**-0.12%** | 8 (0)
73 (0)
4 (0)
306 (0)
23 (0)
328 (0)
6 (0)
347 (0) | | **BootstrapLib** | 316,578 (-11,815) | _createArrayConfig_
_createSingleConfig_ | 1,585 (-97)
1,076 (-16) | **-5.77%**
**-1.47%** | 1,585 (-97)
1,076 (-16) | **-5.77%**
**-1.47%** | 1,585 (-97)
1,076 (-16) | **-5.77%**
**-1.47%** | 1,585 (-97)
1,076 (-16) | **-5.77%**
**-1.47%** | 918 (0)
918 (0) | | **MockRegistry** | 251,252 (-6,692) | _check_ | 322 (-3) | **-0.92%** | 322 (-3) | **-0.92%** | 322 (-3) | **-0.92%** | 322 (-3) | **-0.92%** | 333 (0) | | **NexusAccountFactory** | 625,990 (-15,353) | _computeAccountAddress_
_createAccount_ | 1,327 (-12)
214,797 (-1,270) | **-0.90%**
**-0.59%** | 1,327 (-12)
232,418 (-1,270) | **-0.90%**
**-0.54%** | 1,327 (-12)
234,937 (-1,270) | **-0.90%**
**-0.54%** | 1,327 (-12)
234,937 (-1,270) | **-0.90%**
**-0.54%** | 609 (0)
8 (0) | | **MockNFT** | 1,022,884 (-24,955) | _balanceOf_
_mint_
_ownerOf_
_transferFrom_ | 630 (-4)
68,531 (-8)
572 (-4)
37,726 (-15) | **-0.63%**
**-0.01%**
**-0.69%**
**-0.04%** | 1,630 (-4)
68,675 (-8)
572 (-4)
46,276 (-15) | **-0.24%**
**-0.01%**
**-0.69%**
**-0.03%** | 1,630 (-4)
68,747 (-8)
572 (-4)
46,276 (-15) | **-0.24%**
**-0.01%**
**-0.69%**
**-0.03%** | 2,630 (-4)
68,747 (-8)
572 (-4)
54,826 (-15) | **-0.15%**
**-0.01%**
**-0.69%**
**-0.03%** | 12 (0)
18 (0)
12 (0)
2 (0) | | **MockPaymaster** | 1,063,705 (-29,826) | _addStake_
_getHash_ | 60,499 (-10)
2,168 (-16) | **-0.02%**
**-0.73%** | 60,499 (-10)
2,372 (-16) | **-0.02%**
**-0.67%** | 60,499 (-10)
2,467 (-16) | **-0.02%**
**-0.64%** | 60,499 (-10)
2,665 (-16) | **-0.02%**
**-0.60%** | 15 (0)
16 (0) | | **MockValidator** | 968,013 (-28,992) | _isModuleType_
_isOwner_ | 301 (-2)
681 (-4) | **-0.66%**
**-0.58%** | 301 (-2)
681 (-4) | **-0.66%**
**-0.58%** | 301 (-2)
681 (-4) | **-0.66%**
**-0.58%** | 301 (-2)
681 (-4) | **-0.66%**
**-0.58%** | 309 (0)
274 (0) | | **MockHook** | 270,393 (-11,240) | _isModuleType_ | 312 (-2) | **-0.64%** | 312 (-2) | **-0.64%** | 312 (-2) | **-0.64%** | 312 (-2) | **-0.64%** | 4 (0) | | **MockHandler** | 392,819 (-12,021) | _isModuleType_ | 323 (-2) | **-0.62%** | 323 (-2) | **-0.62%** | 323 (-2) | **-0.62%** | 323 (-2) | **-0.62%** | 5 (0) | | **MockExecutor** | 890,412 (-30,130) | _isModuleType_ | 345 (-2) | **-0.58%** | 345 (-2) | **-0.58%** | 345 (-2) | **-0.58%** | 345 (-2) | **-0.58%** | 11 (0) | | **BiconomyMetaFactory** | 554,420 (-13,354) | _addFactoryToWhitelist_ | 46,209 (-3) | **-0.01%** | 46,209 (-3) | **-0.01%** | 46,209 (-3) | **-0.01%** | 46,209 (-3) | **-0.01%** | 86 (0) |