Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.68%. Comparing base (8a9b410) to head (a5276e0). Report is 2 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #195 +/- ## ======================================= Coverage 85.68% 85.68% ======================================= Files 14 14 Lines 922 922 Branches 253 253 ======================================= Hits 790 790 Misses 117 117 Partials 15 15 ``` ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/195?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/195?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [8a9b410...a5276e0](https://app.codecov.io/gh/bcnmy/nexus/pull/195?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).

openzeppelin-code[bot] commented 1 month ago

refactor: openzeppelin dep

Generated at commit: a5276e0993ac7fa13a8a23e18e3800386ae7978b

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 1
1
0
6
26
34

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 26 34

github-actions[bot] commented 1 month ago

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [locked-ether](#locked-ether) (1 results) (Medium) :yellow_circle: - [unused-return](#unused-return) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## locked-ether :yellow_circle: Impact: Medium :red_circle: Confidence: High - [ ] ID-0 Contract locking ether found: Contract [NexusBootstrap]([utils/NexusBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/utils/NexusBootstrap.sol#L33-L165)) has payable functions: - [ModuleManager.receive()]([base/ModuleManager.sol#L64](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/ModuleManager.sol#L64)) - [ModuleManager.fallback(bytes)]([base/ModuleManager.sol#L67-L69](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/ModuleManager.sol#L67-L69)) But does not have a function to withdraw the ether [utils/NexusBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/utils/NexusBootstrap.sol#L33-L165) ## unused-return :yellow_circle: Impact: Medium :yellow_circle: Confidence: Medium - [ ] ID-1 [ERC7739Validator._hashTypedDataForAccount(address,bytes32)]([base/ERC7739Validator.sol#L279-L309](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/ERC7739Validator.sol#L279-L309)) ignores return value by [(name,version,chainId,verifyingContract) = EIP712(account).eip712Domain()]([base/ERC7739Validator.sol#L280-L288](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/ERC7739Validator.sol#L280-L288)) [base/ERC7739Validator.sol#L279-L309](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/ERC7739Validator.sol#L279-L309) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-2 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/RegistryAdapter.sol#L10)) should be constant [base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/base/RegistryAdapter.sol#L10) - [ ] ID-3 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/2fd217b86907b6e84f19370635c73066aa3eb16c/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.

bcnmy / nexus