refactor: respond to PR comment by 0xbok

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.69%. Comparing base (a9eee7b) to head (d312888). Report is 3 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #198 +/- ## ========================================== - Coverage 85.85% 85.69% -0.16% ========================================== Files 14 14 Lines 933 923 -10 Branches 275 251 -24 ========================================== - Hits 801 791 -10 Misses 117 117 Partials 15 15 ``` | [Files with missing lines](https://app.codecov.io/gh/bcnmy/nexus/pull/198?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) | Coverage Δ | | |---|---|---| | [contracts/modules/validators/K1Validator.sol](https://app.codecov.io/gh/bcnmy/nexus/pull/198?src=pr&el=tree&filepath=contracts%2Fmodules%2Fvalidators%2FK1Validator.sol&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy#diff-Y29udHJhY3RzL21vZHVsZXMvdmFsaWRhdG9ycy9LMVZhbGlkYXRvci5zb2w=) | `70.73% <100.00%> (-3.19%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/bcnmy/nexus/pull/198?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/bcnmy/nexus/pull/198?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Last update [a9eee7b...d312888](https://app.codecov.io/gh/bcnmy/nexus/pull/198?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcnmy).

[openzeppelin-code[bot]]

refactor: respond to PR comment by 0xbok

Generated at commit: d312888d36c38e88820152d162af5a26d233425e

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 26 34

---

For more details view the full report in OpenZeppelin Code Inspector

[github-actions[bot]]

:robot: Slither Analysis Report :mag_right:

Slither report

# Slither report **THIS CHECKLIST IS NOT COMPLETE**. Use `--show-ignored-findings` to show all the results. Summary :yellow_circle: - [locked-ether](#locked-ether) (1 results) (Medium) :yellow_circle: - [unused-return](#unused-return) (1 results) (Medium) - [constable-states](#constable-states) (2 results) (Optimization) ## locked-ether :yellow_circle: Impact: Medium :red_circle: Confidence: High - [ ] ID-0 Contract locking ether found: Contract [NexusBootstrap]([utils/NexusBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/utils/NexusBootstrap.sol#L33-L165)) has payable functions: - [ModuleManager.receive()]([base/ModuleManager.sol#L64](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/ModuleManager.sol#L64)) - [ModuleManager.fallback(bytes)]([base/ModuleManager.sol#L67-L69](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/ModuleManager.sol#L67-L69)) But does not have a function to withdraw the ether [utils/NexusBootstrap.sol#L33-L165](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/utils/NexusBootstrap.sol#L33-L165) ## unused-return :yellow_circle: Impact: Medium :yellow_circle: Confidence: Medium - [ ] ID-1 [ERC7739Validator._hashTypedDataForAccount(address,bytes32)]([base/ERC7739Validator.sol#L279-L309](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/ERC7739Validator.sol#L279-L309)) ignores return value by [(name,version,chainId,verifyingContract) = EIP712(account).eip712Domain()]([base/ERC7739Validator.sol#L280-L288](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/ERC7739Validator.sol#L280-L288)) [base/ERC7739Validator.sol#L279-L309](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/ERC7739Validator.sol#L279-L309) ## constable-states Impact: Optimization :red_circle: Confidence: High - [ ] ID-2 [RegistryAdapter.registry]([base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/RegistryAdapter.sol#L10)) should be constant [base/RegistryAdapter.sol#L10](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/base/RegistryAdapter.sol#L10) - [ ] ID-3 [RegistryFactory.threshold]([factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/factory/RegistryFactory.sol#L39)) should be constant [factory/RegistryFactory.sol#L39](https://github.com/bcnmy/nexus/blob/af007d08b6897ae7e1d4c7836b0e1b2070f57eb0/contracts/contracts/factory/RegistryFactory.sol#L39)

This comment was automatically generated by the GitHub Actions workflow.