bcnmy / scw-contracts

SCW contracts for Biconomy Smart Account
MIT License
123 stars 83 forks source link

SMA-316: Remove dependence on via-ir for compilation #167

Closed ankurdubey521 closed 1 year ago

ankurdubey521 commented 1 year ago

Summary

While we'll still use via-ir while deploying contracts, having contracts that do not require via-ir to be compiled enables the coverage-tracking plugins to work properly. I've made very simple modifications that should in theory not affect the gas consumed by these contracts. But still to be on the safe side, what would be the best way to measure gas (before and after) for the updated modules? @filmakarov

Change Type

Checklist

linear[bot] commented 1 year ago
SMA-316 Remove dependence on via-ir for scw-contracts

While we'll still use via-ir while deploying contracts, having contracts that do not require via-ir to be compiled enables the coverage tracking plugins to work properly

ankurdubey521 commented 1 year ago

@livingrockrises we should still keep via-ir enabled for deploying contracts to production, these changes are just to make sure when coverage is run (which cannot use via-ir) the contracts still compile.

ankurdubey521 commented 1 year ago

@filmakarov it would be great to get your review as well, since you're the primary author of these modules.