bcnmy / scw-contracts

SCW contracts for Biconomy Smart Account
MIT License
115 stars 82 forks source link

SMA-27 Account Recovery Module: fixes upon audit #168

Closed filmakarov closed 10 months ago

filmakarov commented 10 months ago

Summary

TODO: technically validAfter = request.timestamp + securityDelay may overflow as both validAfter and securityDelay are uint48s. Making securityDelay an uint24 should solve issue however it will limit delay to 194 days (which is enough I think). Waiting confirmation from auditors on this matter.

Related Issue: # SMA-27

Change Type

Checklist

linear[bot] commented 10 months ago

SMA-27 Account Recovery Zellic

livingrockrises commented 10 months ago

resolve conflicts

filmakarov commented 10 months ago

all comments addressed