bcnmy / scw-contracts

SCW contracts for Biconomy Smart Account

MIT License

123 stars 83 forks source link

Feat/address resolver #169

Closed livingrockrises closed 1 year ago

livingrockrises commented 1 year ago

Summary

resolves V1 and V2 smart account address for given eoa address and range of deployment indexes. for V2 it assumes default auth module is ECDSA module

latest contract: https://mumbai.polygonscan.com/address/0x46A82fB84089c0cFfE9685ACe7Be821cfd7f441d#readContract

Related Issue: # (issue number)

Change Type

[ ] Bug Fix
[ ] Refactor
[ ] New Feature
[ ] Breaking Change
[ ] Documentation Update
[ ] Performance Improvement
[ ] Other

Checklist

[ ] My code follows this project's style guidelines
[ ] I've reviewed my own code
[ ] I've added comments for any hard-to-understand areas
[ ] I've updated the documentation if necessary
[ ] My changes generate no new warnings
[ ] I've added tests that prove my fix is effective or my feature works
[ ] All unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published

Additional Information

Branch Naming

ankurdubey521 commented 1 year ago

Can we add unit tests for this?

ankurdubey521 commented 1 year ago

Also, since this is not a library it should not be in the libs folder

livingrockrises commented 1 year ago

Can we add unit tests for this?

can add a basic test using V2 factory only and auth modules like ecdsa and multi chain ecdsa.

livingrockrises commented 1 year ago

updated PR https://github.com/bcnmy/scw-contracts/pull/171