bcnmy / scw-contracts

SCW contracts for Biconomy Smart Account

MIT License

123 stars 83 forks source link

SMA-146 Only Module Removal Check #175

Closed filmakarov closed 11 months ago

filmakarov commented 11 months ago

Summary

Added the check to not allow removing the only enabled module

Related Issue: #SMA-146

Change Type

[x] Other

Checklist

[x] My code follows this project's style guidelines
[x] I've reviewed my own code
[x] I've added comments for any hard-to-understand areas
[x] I've updated the documentation if necessary
[x] My changes generate no new warnings
[x] I've added tests that prove my fix is effective or my feature works
[x] All unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published

linear[bot] commented 11 months ago

SMA-146 Implement Check to Prevent Removal of Last Module

This task involves preventing to remove the last module of a smart account. *This is crucial because if all validation modules are removed, the smart account becomes irrecoverable. The goal is to always maintain at least one active module for continued access and functionality.* [https://www.notion.so/Biconomy-Modular-Smart-Account-v3-37f76cef68b643c6bedfef0c020fef53?d=bffd9b5a743c485cb2d6994aec0cfe8b&pvs=4#d34aa5a558974ce180dff6a9e86cf18c](https://www.notion.so/Biconomy-Modular-Smart-Account-v3-37f76cef68b643c6bedfef0c020fef53?d=bffd9b5a743c485cb2d6994aec0cfe8b&pvs=4#d34aa5a558974ce180dff6a9e86cf18c)

livingrockrises commented 11 months ago

nice

livingrockrises commented 11 months ago

I think there is duplicate task on this can you confirm https://linear.app/biconomy/issue/SMA-160/security-fix-for-module-removal

filmakarov commented 11 months ago

I think there is duplicate task on this can you confirm https://linear.app/biconomy/issue/SMA-160/security-fix-for-module-removal

yes, this is duplicate