Discussion: Possible incomplete support for grammars

[sqs]

From https://news.ycombinator.com/item?id=14261611

Thanks for your response over there. :smile:

This grammar file is a good example of one that appears to produce output that differs from C Oniguruma: https://github.com/Microsoft/vscode/blob/master/extensions/typescript/syntaxes/TypeScript.tmLanguage.json.

Here are some examples on our site of where the syntax highlighting has issues:

• https://sourcegraph.com/github.com/sourcegraph/javascript-typescript-langserver/-/blob/src/match-files.ts (e.g., the first two instances of export are colored differently)
• https://sourcegraph.com/github.com/sourcegraph/javascript-typescript-langserver/-/blob/src/connection.ts#L222:12 (e.g., everything after line 219 is colored orange)

VS Code actually has tests of its syntax highlighter that might help to fix the issues. They're in the extensions/vscode-colorize-tests dir in the vscode repo, and individual languages' test fixures are in https://sourcegraph.com/github.com/Microsoft/vscode/-/blob/extensions/typescript/test/colorize-fixtures and its sibling dir colorize-results.

Did you have another better way of testing this lib on real syntax files?

Also, do you have any thoughts about compiling C Oniguruma to WebAssembly?