Overview search

[DeviaVir]

Adding a search button on the top right.

• Opens a dialog
• For now, you can only enter a name to search for
• Pressing the button, or pressing enter, will immediately update the view

It doesn't do any requests to elasticsearch, since we get all elements at the moment. Would probably be nice to have if we would apply pagination and other stuff. But that's for another issue, another day.

11

[bcoe]

@DeviaVir @zeke, how would you feel about having a more Google-style search, where the search bar just sits above the current results?

[DeviaVir]

That's actually not a bad suggestion. I'm off for the weekend as well, but will update this PR with a search window above current results somewhere next week :)

[bcoe]

@DeviaVir, I'm going to put some unit-tests around the current server.js, and will document how the search endpoint accepts: sorting, limiting, and pagination., in a perfect world I'd love the search results to seamlessly let you scroll through your whole collection (perhaps paging in more results as you scroll to the bottom).

I will be tracking this work here: https://github.com/bcoe/record-crate/issues/21

[DeviaVir]

How do you like this? @bcoe

[bcoe]

That's looking good :) two questions:

• can we make hitting enter search.
• will we be able to wire up the new search endpoints?

On Wednesday, December 31, 2014, Chase Sillevis notifications@github.com wrote:

How do you like this?

[image: screen shot 2014-12-31 at 10 54 52] https://cloud.githubusercontent.com/assets/777823/5586900/7af4025a-90db-11e4-982a-70be3e7f780d.png [image: screen shot 2014-12-31 at 10 54 41] https://cloud.githubusercontent.com/assets/777823/5586901/7e26c566-90db-11e4-837c-289c903ad51e.png [image: screen shot 2014-12-31 at 10 54 29] https://cloud.githubusercontent.com/assets/777823/5586902/80beeb82-90db-11e4-90c6-f17d26993f66.png

— Reply to this email directly or view it on GitHub https://github.com/bcoe/record-crate/pull/18#issuecomment-68433051.

[DeviaVir]

There was already some code that was listening for enters, but I messed some stuff up, which broke it. It's working now though!

Which search endpoints do you want me to hit up? Maybe we can talk extending the search later, in another PR. I'm currently already working (in another branch) on implementing the sorting.

[bcoe]

I'm comfortable with addressing these feature requests in another thread. merge at will :+1:

Mainly, I'd like the default search to hit ElasticSearch, but let's open up this conversation in a separate thread so we're not blocking this merge.

[DeviaVir]

Cool! It gives us more chance to go in-depth for issues, per PR :)