bcoe
commented
9 years ago @DeviaVir I can add pagination to search results, just label any server-side work that needs to be done :+1: A few thoughts:
- how do you feel about paging in search results as you hit the bottom of the page?
- I do like being able to page through all the music when finding the next track to play.
- I'll put some work into ranking search results better, so that we can make search hit ES by default and get a good experience.
- How do you feel about adding a search-bar at the top, with a set of controls near it for controlling how search is returned?
- sort by rank, alphabetical, date added, bpm?
Currently we just show all the results from search, probably would be a better idea to show a max of around 100 items (@bcoe, any feedback on this?) and allow for pagination.
Note, that when this is updated, the search in PR #18 will also need to be updated to start querying ES instead of all the results.