check-in assets, making build step optional

bcoe / record-crate

index, organize, and search your music collection, DJ sick sets.

ISC License

25 stars 6 forks source link

check-in assets, making build step optional #22

Closed bcoe closed 9 years ago

bcoe commented 9 years ago

This pull request checks in the assets for record-crate, so that the server can be run without bower or sass.

This makes the npm package able to be run in isolation.
if someone wishes to contribute to the project, there's now a separate npm run build which can be used to re-generate assets, .e.g., css from scss.

CC: @DeviaVir

DeviaVir commented 9 years ago

Mmm.. I understand the wish, but I think we should approach this differently. To commit all the development files will add a huge load of bloat to the git repo.

When you run a grunt build, it will automatically create a dist folder in the root, it's currently in the .gitignore, but maybe you can use that to run the npm package in isolation (then you commit production files).

bcoe commented 9 years ago

@DeviaVir this compromise builds assets at publish time, but does not check them into the git repo.

bcoe commented 9 years ago

Going to go ahead and merge this, but I'm open to more discussion around how we publish npm packages. If you want to try out the current build, I've been releasing it to npm with the tag next.

npm install record-crate@next -g, turns out npm has tags and they're really awesome. Thanks for providing such a great workflow for me to emulate @othiym23.