bcoe / secure-smtpd

Fork of Python's standard SMTP server. Adding support for various extensions to the protocol.
ISC License
128 stars 42 forks source link

Parent worker #10

Closed GrantEdwards closed 10 years ago

GrantEdwards commented 10 years ago

If process_count == 1, then don't use multiprocessing and a pool of child workers. Instead, run asyncore server in what would have been the idle parent process (the same as the standard smtpd module).

GrantEdwards commented 10 years ago

Sure, that sounds like a good idea. I'll work on it and then submit a new pull request.

bcoe commented 10 years ago

@GrantEdwards FYI, I've published version 2.0.0 on PyPi with your updates, try it out -- I'm working on rolling out a new version of smtproutes now.

GrantEdwards commented 10 years ago

The refactoring wasn't difficult but during testing I realized that in the process_count==1 case, ssl exceptions aren't being handled properly. I'll fix that before submitting a new pull request (which will be based on the new master) -- it will probably be a few days...

bcoe commented 10 years ago

@GrantEdwards ever make any progress on this, should I close this pull?

GrantEdwards commented 10 years ago

I haven't had time to work on the SSL exception handling problem. You sould probably go ahead and toss out this pull request. I'll submit another request when I have something ready.

bcoe commented 10 years ago

@GrantEdwards awesome, will happily accept a patch in the future :)