bwallet-cli: require account-key if watch-only

bcoin-org / bclient

Bcoin node and wallet clients

Other

11 stars 20 forks source link

bwallet-cli: require account-key if watch-only #15

Open pinheadmz opened 5 years ago

pinheadmz commented 5 years ago

Addresses possible user error and confusion regarding purpose of watch-only wallets. Not passing an xpub results in a wallet with private keys (bcoin wallet will still generate a master private key) but being watch-only, it will refuse to dump private keys or sign transactions.

See https://github.com/bcoin-org/bcoin/issues/636

pinheadmz commented 5 years ago

Note if a user passes an account-key, the wallet is automatically set to watch-only. This seems ok because it still checks that the key is a pubkey in wallet/http.js so a user may be confused about usage but won't generate unrecoverable private keys.

Kakasipahi commented 3 years ago

i have lost my private key can i derive it by eth address

pinheadmz commented 3 years ago

No. @Kakasipahi