wallet: expose wallet class so it is extendable

bcoin-org / bclient

Bcoin node and wallet clients

Other

11 stars 20 forks source link

wallet: expose wallet class so it is extendable #18

Open BluSyn opened 5 years ago

BluSyn commented 5 years ago

This allows wallet plugins to extend existing Wallet client more easily, without duplicate code.

Example: https://github.com/bcoin-org/bmultisig-client

Concerns: This does result in a breaking change for anything that requires bclient/lib/wallet. Currently the majority of cases I looked into simply require bclient, which I have intentionally left unchanged.

BluSyn commented 5 years ago

If this is merged and released, it should be made a major version bump to prevent breakage with any downstream packages that do a full require of bclient/lib/wallet.