search

bcoin-org / bcoin

Javascript bitcoin library for node.js and browsers
https://bcoin.io
Other
3.01k stars 811 forks source link

node_modules should be removed from the repo #1116

Closed haxwell closed 1 year ago

haxwell commented 1 year ago

Usually, node_modules should not be checked in to the repo.

If anyone needs it, they can just run npm install.

I suggest we remove it, and add the entire node_modules/ directory to the .gitignore.

Also, we should add .idea/ to the .gitignore (intellij project files).

pinheadmz commented 1 year ago

Please read https://github.com/bcoin-org/bcoin/issues/905

haxwell commented 1 year ago

Noted! I understand why node_modules/ is committed to the repo.

What are your thoughts on adding .idea/ to the .gitignore?

pinheadmz commented 1 year ago

I think that has also been brought up in other issues here but that kind of file can be ignored using a master ignore file on your own computer. For example as an OSX user I have to globally ignore DS_Store

pinheadmz commented 1 year ago

See https://github.com/bcoin-org/bcoin/pull/686 ;-)

haxwell commented 1 year ago

Great tip!