Open haxwell opened 1 year ago
@theanmolsharma Thank you for your review.
Each of the it() blocks is to cover a specific condition in the code. The goal is to get 100% coverage. I could merge some of the tests, but there would be paths which were untested.
I will keep this in mind. Please tell me your opinion, though.. When the reviewer-with-write-access merges the PR, they have the option to squash all the PR commits at that time. The same end goal is accomplished. Would you consider that the same either way, whether I do it, or the reviewer does it? Or no?
I am of the opinion that 'sinon', is necessary. If not it, then some other mocking framework. I may be able to test without its functionality, but the test will not be nearly as clear. It is indeed a new library, but I say it is far from clutter.
General thoughts:
it()
blocks can be combined into just one block.