search

bcoin-org / bcoin

Javascript bitcoin library for node.js and browsers
https://bcoin.io
Other
3.01k stars 811 forks source link

ci: migrates CI from Circle CI to Github actions #1144

Closed theanmolsharma closed 1 year ago

theanmolsharma commented 1 year ago

This PR migrates CI from Circle CI to Github actions.

Proof of Work 😜 : https://github.com/theanmolsharma/bcoin/pull/2

masterchief164 commented 1 year ago

Could you please also give an example of the coverallsapp action. The rest of the actions seems great!

masterchief164 commented 1 year ago

Also do create separate issues for the Todos

pinheadmz commented 1 year ago

Yeah I think this looks good, those TODOs can be future PRs. @theanmolsharma is this ready to merge?

theanmolsharma commented 1 year ago

Yeah I think this looks good, those TODOs can be future PRs. @theanmolsharma is this ready to merge?

Not yet ready to merge. Need to investigate options for commenting test coverage report. Preferably something that edits old comments instead of creating a new one everytime the tests run.

masterchief164 commented 1 year ago

Yeah I think this looks good, those TODOs can be future PRs. @theanmolsharma is this ready to merge?

Not yet ready to merge. Need to investigate options for commenting test coverage report. Preferably something that edits old comments instead of creating a new one everytime the tests run.

Maybe the old coverage bot codecov might be helpful. Just found a way to integrate it with github actions This might be helpful.

theanmolsharma commented 1 year ago

@pinheadmz This PR is ready to be merged.