search

bcoin-org / bcoin

Javascript bitcoin library for node.js and browsers
https://bcoin.io
Other
3.01k stars 811 forks source link

`estimatesmartfee` RPC API result inconsistent with Bitcoin Core RPC API (`fee` vs `feerate`) #1153

Closed nkuba closed 1 year ago

nkuba commented 1 year ago

Bitcoin Core RPC API defines the result of estimatesmartfee method to return a feerate property (see: https://developer.bitcoin.org/reference/rpc/estimatesmartfee.html#result).

While Bcoin RPC API returns a fee property instead: https://github.com/bcoin-org/bcoin/blob/92433b24c4afcecc105063ebc66348515718bc36/lib/node/rpc.js#L2233-L2236

The fee property should be renamed to feerate to maintain compatibility across the clients.

theanmolsharma commented 1 year ago

Fixed in https://github.com/bcoin-org/bcoin/commit/014a104899dcd9fafca1bcfea88203ed990a8e90