Closed ChrisCho-H closed 12 months ago
I'd like to see some tests before we get it merged.
I've tested and it works well! You can try mnemonic-test to verify.
Tested ACK. Before we merge, I'd like you to squash all commits into a single commit.
alright
Patch coverage: 50.00
% and no project coverage change.
Comparison is base (
b005869
) 69.55% compared to head (49a0cca
) 69.56%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Where is the word list from? I don't understand the language but it doesn't look like it matches
https://github.com/bitcoinjs/bip39/blob/master/src/wordlists/korean.json
or
https://github.com/bitcoin/bips/blob/master/bip-0039/korean.txt
Same question about the test vectors, where are those from?
It's same with the former one(bitcoinjs/bip39). Test vector is just generated from given seed, and the phrase is one in the wordlist.
ah ok, its just the rendering that confused me,
compare https://github.com/bitcoinjs/bip39/blob/master/src/wordlists/korean.json to https://raw.githubusercontent.com/bitcoinjs/bip39/master/src/wordlists/korean.json
ok please just fix the lint error (single quotes)
line error fixed
Korea is one of the largest in terms of the number of users in crypto. I refer to bip39.js where Korean support is implemented. expect zero harm with useful utility.