Closed ChrisCho-H closed 1 year ago
Patch coverage has no change and project coverage change: -0.02
:warning:
Comparison is base (
b005869
) 69.55% compared to head (5228a00
) 69.54%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I understand where you're coming from but I don't think int53
is a real type? If we do change these messages maybe it should just just say "safe integer" specifically?
It's normally not in use but can be used in some languages where u can set any bit size for int or uint. But for javascript, as u suggested, I think safe integer would sound appropriate enough for error message(number must be below 2^53). I've changed it.
Number.isSafeInteger
is only true when int54. Because here also checks whether positive, it's actually uint53 which can pass these assertions. both int64 and uint64 wrong and misleading