enh: upgrade hashing to SHA-256 for enhanced security

bcoin-org / bcoin

Javascript bitcoin library for node.js and browsers

https://bcoin.io

Other

3.01k stars 811 forks source link

enh: upgrade hashing to SHA-256 for enhanced security #1178

Closed MashyBasker closed 7 months ago

MashyBasker commented 7 months ago

Overview

This pull request updates the hashing algorithms used in the codebase from SHA-1 and MD5 to the more secure SHA-256. The primary motivation behind this change is to enhance the overall security posture of the system by adopting stronger cryptographic standards.

Changes made

Updated the existing(insecure) hashing algorithms SHA-1 and MD5 to the more secure SHA-256

Related issues

fixes #1174

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0c18028) 70.41% compared to head (e8d859d) 70.38%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1178 +/- ## ========================================== - Coverage 70.41% 70.38% -0.04% ========================================== Files 174 174 Lines 27515 27515 ========================================== - Hits 19376 19367 -9 - Misses 8139 8148 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rahulbaghel007 commented 7 months ago

is the issue is resolved ? or need to work to resolve the error related to babel-eslint

MashyBasker commented 7 months ago

The fields where md5 and sha-1 are used aren't for security and are just used for deterministic values. As for the babel-eslint problem, I have created a PR for it to use bslint, similar to the one in bsock.