search

bcoin-org / bcoin

Javascript bitcoin library for node.js and browsers
https://bcoin.io
Other
3.01k stars 811 forks source link

chore: bslint parser config #1180

Closed MashyBasker closed 4 months ago

MashyBasker commented 7 months ago

Overview

Update the .eslintrc.json to support bslint in the CI

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0c18028) 70.41% compared to head (6a5573a) 70.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1180 +/- ## ======================================= Coverage 70.41% 70.41% ======================================= Files 174 174 Lines 27515 27515 ======================================= Hits 19376 19376 Misses 8139 8139 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

theanmolsharma commented 7 months ago

Could you please explain why you made this change? bslint is already working in CI.

MashyBasker commented 7 months ago

The original .eslintrc.json used babel-eslint as the lint parser which caused failure when running lints locally since it was deprecated. Since bslint does not need to be defined in the config file to be used, I made the change to stop using it as the parser and updated the config similar to that of bcrypto