search

bcoin-org / bcrypto

JS crypto library
Other
99 stars 41 forks source link

bech32m is not replaced with bench32m-browser when using browser #66

Closed michalsmiarowski closed 1 year ago

michalsmiarowski commented 2 years ago

lib/encoding/bech32m.js file is not properly replaced with lib/encoding/bech32m-browser.js when using the lib in the browser. I think it's because it's not included in package.json browser field.

Here is the pull request that add support for bech32m - https://github.com/bcoin-org/bcrypto/pull/61. As you can see two new files are created - bech32m.js and bech32m-browser.js. They should be mapped in the browser field in package.json:

browser: {
  ...
  "./lib/encoding/bech32m": "./lib/encoding/bech32m-browser.js",
  ...
}
pinheadmz commented 2 years ago

want to open a PR for this?

michalsmiarowski commented 2 years ago

Sure, I'll open a PR

michalsmiarowski commented 2 years ago

@pinheadmz PR is ready - https://github.com/bcoin-org/bcrypto/pull/67