refactor server files

[HassanJbara]

• create server.views module for http views and extract them from server.api
• extract any extra logic from server.api or server.models to server.utils
• rename upsert_game_state to save_game_state_to_db

I wanted to do this before adding more endpoints and functionality to the server, since I think this structure is more orderly and easier to work with.

[netlify[bot]]

👷 Deploy request for catanatron-staging pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	5639c42a9a64711e534cff6fbe0d0a44bb5201ef

[HassanJbara]

Can you maybe add a section in the readme about the automated tests? For example, I use black-lint myself, so I'm not sure what kind of rules the linter in this pipeline is using and why it keeps failing 😅.

[zarns]

Note: the readthedocs build failure should be resolved in this change: https://github.com/bcollazo/catanatron/pull/281#issuecomment-2241748735

[bcollazo]

Hey @HassanJbara thanks for the PR! That being said, I'm not aligned with this refactoring, so I will kindly close. The api module is already the "view" module (I'm a fan of avoiding 1-line functions that call other functions), and I prefer the original naming.

I see this would also block the Pickle work... so sorry about that. In general, I'd recommend having contributions keep the original architecture / naming structure of the project for now to increase the chances of me accepting. Thanks!