search

bcomnes / deploy-to-neocities

🐈 Github Action to deploy a folder to Neocities
https://github.com/marketplace/actions/deploy-to-neocities
MIT License
177 stars 15 forks source link

Added deployment trigger for merges to master #176

Closed M-Valentino closed 7 months ago

M-Valentino commented 7 months ago

It is a good idea to have this feature for complex repos or repos with multiple contributors.

bcomnes commented 7 months ago

When you merge a pull request, it triggers the push event on the target branch.

M-Valentino commented 7 months ago

Maybe something was happening on Neocities, but it appeared to not trigger for me when I merged into main (I modified the deploy to neocities yaml to target main instead of master)

bcomnes commented 7 months ago

You want it to deploy off the merge commit, not the head commit of the closed pr. This change would trigger on the pr commit on close.

If your default branch is main, then switching the push commit to main should be fine.

Can you share a pr that was merged that didn't trigger?

bcomnes commented 7 months ago

Cleaning up issues and closing this because this would lead to incorrect behavior.