search

bcomnes / npm-run-all2

A CLI tool to run multiple npm-scripts in parallel or sequential. (Maintenance fork)
MIT License
250 stars 12 forks source link

We should commit or disable lockfile #128

Closed voxpelli closed 8 months ago

voxpelli commented 8 months ago

I'm on the side of disabling it

codecov-commenter commented 8 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (79e2c97) 96.82% compared to head (75de9af) 96.31%. Report is 16 commits behind head on master.

Files Patch % Lines
lib/run-task.js 84.81% 12 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #128 +/- ## ========================================== - Coverage 96.82% 96.31% -0.52% ========================================== Files 35 35 Lines 2080 2114 +34 ========================================== + Hits 2014 2036 +22 - Misses 66 78 +12 ``` | [Flag](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/128/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [macos-latest-18](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/128/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `96.22% <84.81%> (-0.53%)` | :arrow_down: | | [ubuntu-latest-18](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/128/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `95.83% <84.81%> (-0.53%)` | :arrow_down: | | [windows-latest-18](https://app.codecov.io/gh/bcomnes/npm-run-all2/pull/128/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `95.85% <84.81%> (-0.53%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bcomnes commented 8 months ago

Package.lock is ignored in .gitignore already. Is this something you can set in your global .npmrc or a local one that is also gitignored in this repo? It's not set up here yet, but I like lock files generated in CI and uploaded as a run artifact that way I can back out the same dependency set locally as a failed run if needed.

voxpelli commented 8 months ago

Right, I'm okay with that :)