bcomnes / sublime-standard-format

:sparkles: Runs standard --fix against the javascript in your ST3 window on save or manually.
https://packagecontrol.io/packages/StandardFormat
MIT License
60 stars 21 forks source link

Fixes a number of .sublime-* files issues + refactoring #88

Closed gacallea closed 2 years ago

gacallea commented 2 years ago
bcomnes commented 2 years ago

Cool! Thanks for all the work. I will look over asap.

bcomnes commented 2 years ago

Sorry, I'm super busy at work this week trying to ship some features, and I'm moving states next week, so I probably won't get to this to the end of the month. Sorry about that :(

gacallea commented 2 years ago

Sorry. I didn't mean to push the most recent changes to this pr... I should have created another branch. My bad.

While we are here, besides removing the toggle command, the other changes are good. The new Package Control policy is NOT to have keybindings and nor context menu anyway. Feel free to close this PR if you don't fancy the new changes.

I'm going to work on the python code as well, and possibly open a new PR that should improve even more. I'm already using this code as my own StandardFormat version in conjunction with more fixed packages (that I'm going to PR as well):

The latter changes fix the code to the new Linter classes and they work great :)

gacallea commented 2 years ago

I think I tried too much... and I made a mess. Have a look at the original PR commits nonetheless, those are valid. closing because I think I'm going back to vs code. Don't have the time to do this on sublime for now.

bcomnes commented 2 years ago

Still planning on taking a look, like I said before, I’m moving this week and on top of it got food poisoning. If you keep the branch around I will take a look sometime next week.