Section 2.5.3 code cleanup opportunity

bcongelio / nfl-analytics-with-r-book

The repo for Introduction to NFL Analytics with R (published with CRC Press)

https://bradcongelio.com/nfl-analytics-with-r-book/

Creative Commons Zero v1.0 Universal

51 stars 15 forks source link

Section 2.5.3 code cleanup opportunity #10

Closed alecglen closed 10 months ago

alecglen commented 11 months ago

From an nflverse Discord comment:

hey @bcongelio looking at this section in the book (2.5.3) - is the additional filter to exclude NAs on the down necessary since you're already asking for a specific down?

bcongelio commented 11 months ago

Good find. The is.na(down) is not needed since down == 3 is present. Adding the 'editorial changes' label and will complete this during the page proof process.

bcongelio commented 10 months ago

Completed in page proofs.