search

bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
3.86k stars 224 forks source link

Suppress logging of repeating errors when retrying automatically #1013

Closed tleedjarv closed 2 months ago

tleedjarv commented 3 months ago

This patch improves the logging in case of automatic retry in repeat mode, which is one of the issues pointed out in #996.

Repeating messages are suppressed only in the log, not on stdout when run interactively.

Easiest reviewed commit by commit.

gdt commented 2 months ago

retry mode is complicated and has a lot of issues. For now, I have decided that I don't want to suppress errors, and that instead people who are concerned about too many errors in the log should instead reduce the rate of errors happening. This may well take a great deal of stepping back and reconsidering many things, but that's ok with me.

tleedjarv commented 2 months ago

I agree, this PR no longer makes sense.