search

bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
4.19k stars 235 forks source link

CI: compat tests are all failing in setup #1063

Closed gdt closed 1 month ago

gdt commented 1 month ago

The compat tests fail with

/usr/bin/docker exec  15fb17bc6fc5f31b1f41e40e1107c3c9b26cd2832a49b0261fa0e1bc4d109577 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)

It may well be time to stop testing compat with old unison, as the new wire protocol has been out for years and everyone should have updated. Further, one can use older, compat-tested versions, as a bridge in updating if necessary. (Indeed; doctrine is that bugs can only be filed against the latest release.)

So I'm inclined to just rm the compat tests as too much effort to keep running, and also too much effort to port to whatever CI platform we move to when we depart github.

Marked as wontfix for fixing, and left here to rm instead after a period for comments.

gdt commented 1 month ago

Also abicheck for windows 2019, which github helpfully won't let me copy/paste from the failure page.

tleedjarv commented 1 month ago

It may well be time to stop testing compat with old unison, as the new wire protocol has been out for years and everyone should have updated. Further, one can use older, compat-tested versions, as a bridge in updating if necessary. (Indeed; doctrine is that bugs can only be filed against the latest release.)

So I'm inclined to just rm the compat tests as too much effort to keep running, and also too much effort to port to whatever CI platform we move to when we depart github.

While it's true that GHA is a constantly moving target, these failures are not about this testing, specifically. In other words, the rm would not save us from similar headaches in the future. I'll open a PR with fixes for the currently active errors but we'll surely have to discuss the long term strategy separately.