bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
4.04k stars 228 forks source link

Decide on pruning old ocaml support #653

Closed gdt closed 2 years ago

gdt commented 2 years ago

Unison currently supports ocaml 4.01 to 4.13 and seems to work on pre-release versions of 4.14 and 5. Starting with 2.52.0, it will no longer be necessary to have matching ocaml versions, so part of the motivation for building with old ocaml (accomodating updates on old systems) will no longer apply. See https://github.com/bcpierce00/unison/wiki/ocaml-versions for discussion.

There are pending changes to use GTK3 instead of GTK2. GTK2 is unmaintained, and even GTK3 is "old stable". It seems that lablgtk for GTK3 does not build with 4.01.

Besides GTK3, support for old ocaml clutters the code.

Therefore, after 2.52.0, and probably after confidence that a 2.52.n version is stable with no major isssues relative to 2.51.x, we should decide on a new minimum ocaml version for Unison. In addition, we should understand if "you must have lablgtk 3 installed" is effectively an ocaml version requirement for those that wish to build the GUI.

gdt commented 2 years ago

Possibilities include:

I'm omitting moving to 4.11, as while that will surely happen eventually, this is about the next change, and it seems obvious to me that moving to >=4.11 in a few months is too aggressive.

gdt commented 2 years ago

Discussion on unison-hackers@ please; this sort of doesn't belong in the issue tracker but I wanted to have it on the record and to have something to point to.

gdt commented 2 years ago

The draft plan is 4.08, because lablgtk3 works with that. Discussion still welcome on unison-hackers. Merging version requirement changes is on hold until 2.52.1, happening in 2-6 weeks.

gdt commented 2 years ago

The major outliers from 4.08 seems to be:

If there are reasons other than those two, please explain.

gdt commented 2 years ago

We continue to be on plan mostly:

gdt commented 2 years ago

We have decided: 4.08 is the new minimum.

bcpierce00 commented 1 year ago

FWIW all this seems reasonable to me.

   - Benjamin

On Mar 13, 2022, at 1:45 PM, Greg Troxel @.***> wrote:

 The major outliers from 4.08 seems to be:

perhaps very old RHEL/etc., but they also stay with old unison, so I think that's ok. They'll just be stuck at 2.52.1 unless they also want to build ocaml before they build unison. FreeBSD ports is at 4.06. I emailed the maintainer and have not heard back. If there are reasons other than those two, please explain.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

bcpierce00 commented 1 year ago

P.S. No idea why this just appeared yesterday! I wrote it months ago...

On Tue, Oct 11, 2022 at 3:32 AM Benjamin Pierce @.***> wrote:

FWIW all this seems reasonable to me.

  • Benjamin

On Mar 13, 2022, at 1:45 PM, Greg Troxel @.***> wrote:

 The major outliers from 4.08 seems to be:

perhaps very old RHEL/etc., but they also stay with old unison, so I think that's ok. They'll just be stuck at 2.52.1 unless they also want to build ocaml before they build unison. FreeBSD ports is at 4.06. I emailed the maintainer and have not heard back. If there are reasons other than those two, please explain.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you are subscribed to this thread.

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/bcpierce00/unison/issues/653*issuecomment-1274218129__;Iw!!IBzWLUs!XyLeZ-69mMgHE4WvOsbhfbdbyeZT6VANanGw7Pv3TXK7ZLKpis8a1P4cOEmH8wgvmr3_34zZVY70GF4OzE_dGZHnD-Jf$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABVQQC3HGWKBB45RFYQ7FELWCUJXJANCNFSM5PPFBICQ__;!!IBzWLUs!XyLeZ-69mMgHE4WvOsbhfbdbyeZT6VANanGw7Pv3TXK7ZLKpis8a1P4cOEmH8wgvmr3_34zZVY70GF4OzE_dGfMkUwp2$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>