bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
4.15k stars 234 forks source link

Fix typos #849

Closed kianmeng closed 1 year ago

kianmeng commented 1 year ago

Found via:

tleedjarv commented 1 year ago

Overall, I'm a bit hesitant towards changing actual code under the umbrella of "fixing typos".

gdt commented 1 year ago

I am hesitant too, although I am sympathetic to fixing where it is not problematic. I don't really have cycles to dig in hard right now.

@kianmeng Could you amend (or new, whatever) to just files for human reading? That seems mergeable much more easily and we'll get half done, arguably the more important half.

kianmeng commented 1 year ago

@gdt Noted. I've reverted changes to the source code and keep only those in comments and documentation. Let me know if I miss out anything.

gdt commented 1 year ago

Looks good to me, but would appreciate someone else reviewing too.

I approved running the CI workflow; obviously that has to pass but I am pretty sure it will.

gdt commented 1 year ago

@kianmeng Thanks for contributing.

kianmeng commented 1 year ago

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face: