While this leak has always been present, it didn't mostly matter the way Lwt.choose was used so far. There was only one case (socket server) which was really impacted by this and even then you'd have to connect (tens or hundreds of) thousands of times to the same process for the leak to become practically harmful.
Now with the code for graceful stop of repeat mode (not yet merged), which also uses Lwt.choose, the leak becomes potentially scary. It's got to go for good.
While this leak has always been present, it didn't mostly matter the way
Lwt.choosewas used so far. There was only one case (socket server) which was really impacted by this and even then you'd have to connect (tens or hundreds of) thousands of times to the same process for the leak to become practically harmful.Now with the code for graceful stop of repeat mode (not yet merged), which also uses
Lwt.choose, the leak becomes potentially scary. It's got to go for good.