bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
4.01k stars 227 forks source link

Combine filesystem monitoring and time interval in repeat mode #861

Closed tleedjarv closed 1 year ago

tleedjarv commented 1 year ago

Currently the repeat mode allows the user to specify either time interval only or filesystem monitoring only. It makes sense to allow combinining these two modes because filesystem monitoring may not always be fully reliable (due to bugs or platform limitations, or is just perceived a little untrustworthy).

This is not a breaking change because while this preference is sent to the server (incorrectly, among several other preferences, due to legacy limitations), the value of the preference is never parsed on the server before commit 5d6ab3cb9921a476e73e42307d40addc1b86f30a (which is not in any release so far).

Edit: Include a commit to fix the potential future compatibility issue introduced by commit 5d6ab3cb9921a476e73e42307d40addc1b86f30a. @gdt this fix should be merged before the next release even if this entire PR is not merged. Let me know if you want me to split it out as a separate PR.