bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
4.01k stars 227 forks source link

GHA: Fix Windows packaging (include missing DLLs) #880

Closed tleedjarv closed 1 year ago

tleedjarv commented 1 year ago

As pointed out by https://github.com/bcpierce00/unison/issues/186#issuecomment-1477978644 the CI artifacts for Windows were not quite complete and couldn't be run on a clean install.

The CI Windows packaging step was broken. The reasons are unknown but one symptom which caused the packages to be incomplete was something(what?) mangling the PATH. Fixing the PATH manually also fixed the packaging (however, setting this PATH in earlier steps where other PATH entries are set does not work).

The binutils workaround is no longer available (Cygwin no longer ships binutils verson 2.37) so remove it. Fortunately, the issue that caused the workaround to be added seems to be gone. Closes #747