bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
4.01k stars 227 forks source link

Fix broken Windows GUI builds #887

Closed tleedjarv closed 1 year ago

tleedjarv commented 1 year ago

The cause of broken Windows GUI builds (when the EXE does not start and does not even produce any error messages) appears to be this usage of GPointer.blit.

There are two noteworthy things about this, though. First, this code has been there since 2005 and never caused any problems. The problems only appeared with binutils > 2.37 (which is why binutils were pinned to 2.37 in the CI script for almost a year). Second, not all machines are apparently equally impacted. On some machines, or under some conditions, the EXE would start normally.

Just for the record, referencing issues: #738, #744