bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
3.9k stars 225 forks source link

Add a more sensible install target in Makefile #939

Closed tleedjarv closed 5 months ago

tleedjarv commented 1 year ago

Provide a basic install target. Not intended to work on Windows but should work on most POSIX-y systems that have a BSD- or GNU-compatible install.

@gdt could you review if this works for packagers?

tleedjarv commented 9 months ago

Rebased and updated. Now all variables should be env-able. In fact, variables from env will override GNU-style lowercase variables.

jhjourdan commented 5 months ago

Is there anything blocking this PR? Should we merge?

It seems like no reviewer raised any issue, and, as far as I can tell, the target is doing what is needed ;)

Also, this PR is a dependency for #845, which I'm trying to push.

gdt commented 5 months ago

I tested on NetBSD and was able to control PREFIX and MANDIR from the environment, so I'm now ok with this.