search

bcpierce00 / unison

Unison file synchronizer
GNU General Public License v3.0
3.86k stars 224 forks source link

Part of the column headers of the comparison results are unreadable #959

Closed Korb closed 9 months ago

Korb commented 10 months ago

It is not clear what is displayed in the title of the two columns with the values "chgd dir", "deleted", "new file" and "props":

Screenshot_2023-09-07_12-28-30 cropped

Unison File Synchronizer 2.53.3 / unison-gui.exe Microsoft Windows 10.0.19045.3393 ("use Unicode UTF-8 for worldwide language support" setting in "on")

tleedjarv commented 10 months ago

It seems there are two separate issues here.

First, it appears that UTF-8 processing is broken. If that's the case then a fix will be provided shortly.

Second, the titles of the two columns are just too short to be useful. This is a known issue: #506 is one such example, there are probably more.

gdt commented 9 months ago

There are multiple things and issues need to be granular. @Korb could you test #962? That will almost certainly get merged in a week. Then, it would probably be good to open issues that say "column says X and it should say Y", assuming that Y is not much longer. We can't just expand everything. If it is more complicated than a specific sugestion that is fairly clearly reasonable, please instead open a discussion on unison-users@.

gdt commented 9 months ago

I'm going to declare that this issue is about the UTF-8 mishandling, so it will be closed when that is merged. That doesn't mean other things aren't wrong, just that we can't handle multiple separable things in one issue.

Korb commented 9 months ago

There are multiple things and issues need to be granular. @Korb could you test #962?

I don't know how exactly to do this, sorry.

gdt commented 9 months ago

https://github.com/bcpierce00/unison/actions/runs/6113238365?pr=962 and scroll down to artifacts. These are builds with the proposed fix.

Korb commented 9 months ago

Probably the problem can be considered solved:

Screenshot_2023-09-18_11-14-53

Yes, even if the names of the synchronized folders are the same, it is not obvious which column belongs to which location. But that's another problem.

tleedjarv commented 9 months ago

Pushed a small update to the PR, correcting an issue with underscores (a bug that seems to have been there for a long time). If you'd like, you can test the build at https://github.com/bcpierce00/unison/actions/runs/6220749068?pr=962

gdt commented 9 months ago

The PR has been merged, so I'm calling this fixed. Please feel free to open issues for outright bugs and specific, well-articulated feature requests, and to bring anything else up on the mailninglist.