bcssov / IronyModManager

Mod Manager for Paradox Games. Official Discord: https://discord.gg/t9JmY8KFrV
https://bcssov.github.io/IronyModManager/
MIT License
338 stars 40 forks source link

Don't compress music mods, just smush them all together into a loose file mod in the local mod folder #321

Closed LordOfLA closed 2 years ago

LordOfLA commented 2 years ago

As title. Would reduce compress merge times a fair amount, potentially save disk space since the .ogg files are compressed audio anyway afaik.

bcssov commented 2 years ago

That would significantly complicate the logic with no real benefit to the overall logic. Will think this through.

LordOfLA commented 2 years ago

Could also just skip processing mods that contain only music + asset file for said music, let them load as-is from the workshop folder. It isn't as though music mods are limited to game versions at the moment.

bcssov commented 2 years ago

This is a really low priority.

  1. It adds nothing to the program or overall really
  2. It complicates already complex logic
  3. Additional complexity comes when a music mod is not just a music mod but a hybrid of whatever where someone decides to add to it gfx, events what not
LordOfLA commented 2 years ago

Can be as low as you want. It's a qol / time saving feature for users and probably the driving desire for the "don't repack unchanged mods" feature request.

Plus the request is for just music mods not mods with music and other stuff. Really easy to tell what those mods are and easy to therefore skip.

bcssov commented 2 years ago

This is outdated.