Closed chester89 closed 8 years ago
Sure, go ahead.
Ok, I'll try to have something working next week
2016-08-02 19:34 GMT+03:00 Brandon notifications@github.com:
Sure, go ahead.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bcuff/GeocodeSharp/issues/13#issuecomment-236962298, or mute the thread https://github.com/notifications/unsubscribe-auth/AALnfPiuehppmdm9k1jehJf3xYI-VzQ-ks5qb3GKgaJpZM4JavDi .
Yours faithfully, Gleb
:+1:
My changes will likely break public API (ctor parameters). Should I try to avoid that or are you fine with bumping version to 2.0?
Actually, I won't break it - will just add one more constructor
Given that 2500 req/day is a free limit, I'm thinking about using a proxy for this library. I personally have multiple projects that utilize Geocoding API, and daily volumes will only increase from this point forward. Unfortunately, proxy usage can vary by server implementation. Would you be open to a slight refactoring - introducing something like
IRequestExecutor
with default implementation being current logic, but so we can plug in any other technique (sending requests through nginx, for example)? I would volunteer for this, of course.