search

bcuff / elasticsearch-net-aws

Add-on to Elasticsearch.Net & NEST for using AWS's elasticsearch service.
Apache License 2.0
72 stars 27 forks source link

asp.net core #13

Closed adrianclaveri closed 7 years ago

adrianclaveri commented 8 years ago

Hi, any thoughts on implementing this for asp.net core?

Thanks

bcuff commented 8 years ago

Yeah, I ran a portability analyzer on it. There are a few things to fix but not many. I'll work on it.

adrianclaveri commented 7 years ago

Awesome! Looking forward to it.

Thanks!

davemcdermid commented 7 years ago

Hi, what's the status of the netcore branch - is it close to a beta/pre-release state? Happy to assist if required or provide testing.

Thanks

bcuff commented 7 years ago

Ah, you've just reminded me to finish that up. I'll work on it. I should have a release soon.

nanestev commented 7 years ago

@bcuff, I also needed your library for a netcore app and had to port it. It targets net45 and netstandard1.3 which covers lots of frameworks and versions. Here is my pull request #16

bcuff commented 7 years ago

@nanestev thanks for the PR! I was actually almost done with a netcore port myself. See the netcore branch. I'll take a look at yours though. It looks like your implementation is more complete.

bcuff commented 7 years ago

Also, I granted you push rights so you don't have to fork to make changes in the future.

nanestev commented 7 years ago

Yeah, I saw your branch a bit too late otherwise I would have worked on top of your changes. Anyway, let me know if there is a problem with my version. Cheers